broulik added inline comments.
INLINE COMMENTS
> content-script.js:177
> + if (activePlayer) {
> + if (!(activePlayer.seekable.length > 0)) {
> + console.warn("Got seek command, but player is not seekable");
Please avoid negating a longer statement, this makes the code hard to
understand at a glance:
if (activePlayer.seekable.length === 0)
> mokhtari wrote in mprisplugin.cpp:205
> MPrisPlugin doesn't define Seeked, so no. But it's fine with me if you think
> adding it to the parent and using the signal auto-relaying would be better.
>
> Regarding macros vs. keywords, I just figured macros would be more
> compatible, but it could be switched to using emit as well.
Doesn't it work if you define the signal in `mprisplugin.h` and emit there? The
generated DBus code from the XML should auto-relay them. Agreed, it's somewhat
magic.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D13717
To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux,
Danial0_0, johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg,
jeanv, ZrenBot, seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed,
jensreuterberg, ach, abetts, sebas, apol, mart
