nicolasfella requested changes to this revision. nicolasfella added a reviewer: drosca. nicolasfella added a comment. This revision now requires changes to proceed.
This breaks the profile selection Combobox in the KCM. From the libpulse doc <https://freedesktop.org/software/pulseaudio/doxygen/structpa__card__profile__info2.html#a9c32760168c4151aa4716f2bd9fab434> on Profile: > Is this profile available? If this is zero, meaning "unavailable", then it makes no sense to try to activate this profile. > If this is non-zero, it's still not a guarantee that activating the profile will result in anything useful, it just means that the server isn't aware of any reason why the profile would definitely be useless. So anything different to zero should be interpreted as Profile::Available. If a profile reports 1 it should be interpreted as Available, but now would result in PA_PORT_AVAILABLE_NO. From libpulse: typedef enum pa_port_available { PA_PORT_AVAILABLE_UNKNOWN = 0, /**< This port does not support jack detection \since 2.0 */ PA_PORT_AVAILABLE_NO = 1, /**< This port is not available, likely because the jack is not plugged in. \since 2.0 */ PA_PORT_AVAILABLE_YES = 2, /**< This port is available, likely because the jack is plugged in. \since 2.0 */ } pa_port_available_t; /** \cond fulldocs */ #define PA_PORT_AVAILABLE_UNKNOWN PA_PORT_AVAILABLE_UNKNOWN #define PA_PORT_AVAILABLE_NO PA_PORT_AVAILABLE_NO #define PA_PORT_AVAILABLE_YES PA_PORT_AVAILABLE_YES Assuming the idea behind your patch is correct it should be moved to the Port class. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13694 To: akrutzler, nicolasfella, broulik, drosca Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
