bruns added a comment.
@sharvey can you address the remaining nitpicks? INLINE COMMENTS > sharvey wrote in AuthDialog.cpp:349 > I was checking to see if this was still open, and would like to discuss > "Missing". I considered "Missing" while I was originally coding this, but > thought it sounded a little negative, like we weren't able to access the > information. I realize that "Missing" is the official response per the FDO > spec, could we settle on something like "Not Provided"? After all, it's not > //our fault// the information is missing. Just an idea. I prefer 'missing', to give upstream a 'hint' they are doing something wrong. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To: sharvey, bruns, ngraham, davidedmundson Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
