ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
Love it! Two issues that I can see: - In this example, the text really needs to be white; it doesn't show up well against the dark green background. If the color is programmatically determined, we may need some fancy logic to choose the button's text color to ensure that it's visible enough. For that matter, the icon doesn't show up very well either... - The button has no right padding, and touches the window edge ( A Discover issue?) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13237 To: apol, #kirigami, mart, ngraham Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein
