arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. arojas requested review of this revision.
REVISION SUMMARY Having discover handle .deb packages is useless in non-Debian based distros. Same for .rpm. Almost all the times someone clicks on a .deb or .rpm file in a distro with a different package format they expect the archive to be opened in an archive extractor. Having it open in discover is annoying -at the very least- and potentially dangerous (if, for some reason, the wrong PK backend is installed, Discover may try to install the package, which could wreck the system). This patch makes handling of .deb and .rpm optional at build time. TEST PLAN Tested all possible combinations of HANDLE_DEB and HANDLE_RPM, MimeType field in org.kde.discover.desktop contains the expected value every time. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13123 AFFECTED FILES discover/CMakeLists.txt To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
