adridg added a comment.
Comments directed at licensing and non-Linux cases. INLINE COMMENTS > queryptrace.cpp:1 > +#include <QCoreApplication> > + Missing file header / license bits > queryptrace.cpp:49 > + > +#endif For non-Linuxen, include a null implementation here. > queryptrace.h:1 > +#ifndef QUERYPTRACE_H > +#define QUERYPTRACE_H Missing a file header / license bits > queryptrace.h:5 > +#ifdef Q_OS_LINUX > +void queryPtrace(long long pid); > +#else You used qint64 elsewhere > queryptrace.h:7 > +#else > +#define queryPtrace(x) > +#endif In general, and for type safety, I'd avoid using #ifdefs to define an API. There should probably be **only** the one declaration of queryPtrace. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks Cc: adridg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
