broulik added inline comments.

INLINE COMMENTS

> powerdevilupowerbackend.cpp:406
>  
> -    setBrightness(newBrightness, controlType);
> +    if (newBrightness != currentBrightness) {
> +        setBrightness(newBrightness, controlType);

Can we be sure that the `currentBrightness` is always up-to-date? We must still 
be able to force a new brightness if the hardware forgot to tell us or changed 
it outside our realm of influence

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13030

To: thsurrel
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to