ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Nicely done! Code and visual changes look good to me. Tested it out and
everything still works. Just two little comment formatting nitpicks, then this
is good to go from my perspective! (wait for other reviews too before landing,
please)
INLINE COMMENTS
> main.qml:32
>
> - Layouts.ColumnLayout {
> - id: maincol
> - spacing: units.largeSpacing
> + // VisaulBehavior Settings
> + Controls.CheckBox {
"Visual behavior settings"
> main.qml:57
>
> - Controls.CheckBox {
> - id: showVisualFeedback
> - text: i18n("Display visual feedback for status changes")
> - checked: kcm.visualFeedback
> - onCheckedChanged: kcm.visualFeedback = checked
> - }
> + // ClickBehavior Settings
> + Controls.ExclusiveGroup {
"Click behavior settings"
REPOSITORY
R119 Plasma Desktop
BRANCH
kcmworkspace-Redesign
REVISION DETAIL
https://phabricator.kde.org/D12973
To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
