davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed.
It might work, but it's overly messy. We have addAccountToCache which has an argument pos, which determines if we're adding or replacing. Then we have a second replace method replaceAccount which also does replacing. So we have two ways of replacing an entry both and both are used once, and they're both identical except for a very subtle change on usage of m_userPath. I'm sure we can do something better. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D12837 To: valeriymalov, #plasma, davidedmundson Cc: davidedmundson, ngraham, rdieter, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
