aacid added a comment.

  The other option would be not using findNetworkInterface at all since we're 
already doing qobject_cast<NetworkManager::Device*>(sender()) we already have 
the device, we don't really need to do a round-trip, but wihtout knowing this 
code at all it seems like if NetworkManager::findNetworkInterface doesn't find 
the interface it's because it's being dropped (which makes sense with the bug 
being about "crash when discoonecting VPN") so it seems better to just ignore 
the connection at that point.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D12716

To: aacid, #plasma, jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to