broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY This completely drops the icon customization with icon effects and only retains the icon size settings. I also couldn't find any trace of that "animations enabled" check box it used to have. It adds drag and drop support for installing archives as themes. It can also download them from remote location when dropped from e.g. a browser. Installing theme files actually never worked in Plasma 5 as it got broken in the port from KIO NetAccess to storedGet. Implements T7262 <https://phabricator.kde.org/T7262> TEST PLAN TODO: - Figure out "Reset to defaults", it reverts to "hicolor" and then you end up with no icons. The old KCM just stored the "current" theme and resets to that - Applying settings for kde4 apps - Remove the old code, perhaps split out the icon effects stuff as separate expert tool? F5818181: Screenshot_20180422_222955.png <https://phabricator.kde.org/F5818181> Icon size config flyout, I chose not to use a separate page as in the mockup as it's really just the size settings now: F5818182: Screenshot_20180422_223212.png <https://phabricator.kde.org/F5818182> The slider shows the possible size steps F5818183: Screenshot_20180422_223222.png <https://phabricator.kde.org/F5818183> Removing installed theme F5818184: Screenshot_20180422_223253.png <https://phabricator.kde.org/F5818184> It comes with an undo feature and only if you hit Apply or OK it will acutally delete the themes, so you can undo individual or all (by using Revert button) deletions. If this is accepted, I'll look into rolling this out to the other KCMs that allow permanently deleting actual files. It is inspired by wallpaper settings. F5818185: Screenshot_20180422_223325.png <https://phabricator.kde.org/F5818185> Installing theme with `InlineMessage` F5818186: Screenshot_20180422_223348.png <https://phabricator.kde.org/F5818186> REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12459 AFFECTED FILES kcms/icons/CMakeLists.txt kcms/icons/Messages.sh kcms/icons/icons.desktop kcms/icons/kcm_icons.desktop kcms/icons/main.cpp kcms/icons/main.h kcms/icons/package/contents/ui/IconSizePopup.qml kcms/icons/package/contents/ui/main.qml kcms/icons/package/metadata.desktop kcms/icons/tests/CMakeLists.txt kcms/icons/tests/testicons.cpp To: broulik, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
