davidedmundson added a comment.

  I'm a bit confused by a few things.
  
  1. We seem to have our own generic ksplash package format already. See 
KCMSplashScreen::load  ~128
  
  Which isn't deleted. How do your changes tie in with that - and with the 
existing themes?
  
  2. What's the advantage of using a separate package over re-using LnF 
packages with just ksplash in it.

INLINE COMMENTS

> kcm.cpp:152
>  
>      const QList<Plasma::Package> pkgs = 
> availablePackages(QStringLiteral("splashmainscript"));
>      for (const Plasma::Package &pkg : pkgs) {

This is loading separate splash packages

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11919

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to