davidedmundson added inline comments.

INLINE COMMENTS

> libinput_settings.cpp:26
> +{
> +    KConfig config("kcminputrc");
> +    KConfigGroup group = config.group("Mouse");

KConfig("foo")
will load foo and parse it every time.

> libinput_settings.h:27
> +    template<class T>
> +    T load(QString key, T defVal);
>  

this use of templates doesn't match the implementation

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: davidedmundson, hein, mart, abetts, ngraham, plasma-devel, ragreen, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

Reply via email to