anthonyfieroni added inline comments.

INLINE COMMENTS

> backgroundlistmodel.cpp:532
>  
> -        m_suffixes = suffixes.toList();
> +        s_suffixes = suffixes.toList();
>      }

Potentially it still can produce a crash, the function returns a reference to 
list, simultaneously read/write on list is race condition. So function can 
return a copy to static list for this function, then global variables or 
mutexes doesn't needed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11590

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to