davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision.
REVISION SUMMARY I'm not the author, but it's pretty clear what the intention was. We expect to get one result back from proxyModel->match We use results.first(), so we want to check we have at least one entry. The assert was written backwards BUG: 387444 TEST PLAN Can now remove a group without a crash REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D11567 AFFECTED FILES kcms/keys/kglobalshortcutseditor.cpp To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart