romangg added inline comments. INLINE COMMENTS
> romangg wrote in drm_output.h:139 > Is it only a friend class to access `m_waylandOutput.data()`? In this case > better create a getter for it in DrmOutput. > > Or better do the `passBuffer` call in `DrmBackend::present` and give instead > of the DrmOutput the `KWayland::Server::OutputInterface` from there to > `passBuffer`. Regarding the "better" part: you would need the `m_remoteaccessManager` in `DrmBackend`. Only with EGL/GBM this would then be set. I.e. in QPainter `DrmBackend` would ignore it. But that's maybe a bit too much (also you would need to change the buffer cast in passBuffer). So better just add a getter in DrmOutput. REPOSITORY R108 KWin BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
