gregormi added a comment.
In D10297#207127 <https://phabricator.kde.org/D10297#207127>, @rkflx wrote: > Just tried the patch. I think for System Activity / [Ctrl] + [⎋] the button is fine (annoyingly with a slightly larger height than the combobox, but that's life…). For KSysGuard itself it looks a bit odd, why would it appear exactly on this tab page? I could imagine the menubar would be a better place. > > (Sorry this comes so late, I only reviewed in more detail because nobody from Plasma bothered so far. Ignore my comment if you want.) Some people from Plasma reviewed the original review request on reviewboard. Should we add some more reviewers before it can go in? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
