kossebau created this revision. kossebau added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision.
REVISION SUMMARY Patch inlines the code of the constructor and destructor of the old QApplication subclass PolicyKitKDE and then reorders things as needed: - KDBusService for singleton run should be started before any further init - KLocalizedString::setApplicationDomain & i18n calls should be only done after the QApp instance has been created - KAboutData::setApplicationData best done before doing any D-Bus activity as that relies on app metadata - QCoreApplication::setOrganizationDomain duplicates app metadata setting from KAboutData::setApplicationData, only needed before due to latter done after first D-Bus activity - m_listener->deleteLater() in app destructor does not make sense, as the listener object is deleted due to being QObject child of the QApplication instance REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH fixappinitorder REVISION DETAIL https://phabricator.kde.org/D11106 AFFECTED FILES CMakeLists.txt main.cpp policykitkde.cpp policykitkde.h To: kossebau, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
