kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision.
REVISION SUMMARY Currently the media controller in the tooltup only works with MPRIS services which support the PlayPause command. By the MPRIS spec this is an optional feature though. While most players out there support this, the MPRIS support in Gwenview currently worked on does not (would need some more rewrite of internals). Which makes the media controller in the tooltip and/or Gwenview look broken :) To keep the current design with a central Play/Not Play button, this patch changes its behaviour depending on the CanPause flag: CanPause=true -> show either Play or Pause CanPause=false -> show either Pkay or Stop That should stay close to what people need. TEST PLAN Works with Gwenview patched with MPRIS support, button toggles between play/stop, depending on state. Works with VLC, button toggles between play/pause (but might need more testingg to add some work-arounds perhaps needed with vlc as hinted by broulik) REPOSITORY R119 Plasma Desktop BRANCH fixtaskmanagertooltipformpris REVISION DETAIL https://phabricator.kde.org/D11025 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipInstance.qml To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
