ngraham added a comment.

  Generally looks good. A few UI comments:
  
  - Let's use a hamburger icon as the default icon, rather than the three-dot 
icon. That's used elsewhere on the list to expose hidden actions; here, it's 
opening a standard drop-down menu, so let's use the more standard icon for it.
  - The button doesn't have enough right padding: F5737034: Not enough 
padding.png <https://phabricator.kde.org/F5737034>
  - I'm not really satisfied with the presentation when the button has text, as 
seen above; there's no icon, and no downward-pointing arrow  to indicate that 
clicking the button will open a drop-down menu.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

Reply via email to