kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision.
REVISION SUMMARY Currently the media controller only works with MPRIS services which support the PlayPause command. By the MPRIS spec this is an optional feature though. While most players out there support this, the MPRIS support in Gwenview currently worked on does not (would need some more rewrite of internals). Which makes the Media controller applet and/or Gwenview look broken :) To keep the current design with a central Play/Not Play button, this patch changes its behaviour depending on the CanPause flag: CanPause=true -> show either Play or Pause CanPause=false -> show either Pkay or Stop That should stay close to what people need. TEST PLAN Works with Gwenview patched with MPRIS support. Works with VLC, but might need more testing to add some work-arounds as mentioned before by broulik. REPOSITORY R120 Plasma Workspace BRANCH mpriscontrollersupportnocanpause REVISION DETAIL https://phabricator.kde.org/D10973 AFFECTED FILES applets/mediacontroller/contents/ui/ExpandedRepresentation.qml applets/mediacontroller/contents/ui/main.qml To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
