mart added inline comments. INLINE COMMENTS
> davidedmundson wrote in ExpandedRepresentation.qml:29 > How does this avoid a useless Dialog resize? otherwise mainItem starts being sized 0x0, then on Dialog showevent, it searches for its Layout property and resizes it based on that, this makes the resize being a noop which seems a sensible micro optimization > davidedmundson wrote in systemtray.cpp:346 > why did this need special code, but kicker (not kickoff) which also does its > own didn't? ah, if kicker doesn't use expandedrepresentation then it's not done there, tough i feel that whether qwindow::create is actually useful or not really would need better profiling, which i'm not sure how to do REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
