kossebau added a comment.
Not tested, but seems good to me by pure reading. INLINE COMMENTS > ConfigWeatherStation.qml:33 > + > + property bool acceptOnReturnPressed: !searchStringEdit.activeFocus || > searchStringEdit.length === 0 > Slightly undecided: given above we use the `length` property as implicit bool, dping a value comparison here instead seems inconsistent. Just saying, no own preference and not enough years of JS/QML done to have strong opinions about it :) Do we have some accepted JS tricks with Plasma code style? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
