davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Analysis seems fine.
Solution can be better. Lets try to avoid any hardcoded values. You can get
icon sizes from the Units too.
INLINE COMMENTS
> BatteryIcon.qml:42
> anchors.centerIn: parent
> - width: units.roundToIconSize(Math.min(parent.width, parent.height))
> + width: units.roundToIconSize(Math.max(Math.min(parent.width,
> parent.height), 22)) // Battery icons are at least 22px large
> height: width
so the icon will be bigger than the parent?
That's messy
> Main.qml:299
> //Footer
> RowLayout {
> id: footer
currently this is based on the implicitHeight of the biggest child item, we
shouldn't be hardcoding things here.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10633
To: guoyunhe, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
