michaelh created this revision.
michaelh added reviewers: Plasma, Plasma: Workspaces.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
michaelh requested review of this revision.
REVISION SUMMARY
This diff is purely informational.
Without this patch compilation of plasma-workspace fails with:
~/bin/kde-latest/include/ksysguard/processcore/processes.h:61:54:
error: ‘null’ is not a member of ‘QString’
Processes(const QString &hostname = QString::null, QObject *
parent = nullptr);
^~~~
make[2]: *** [systemmonitor/CMakeFiles/systemmonitor.dir/build.make:63:
systemmonitor/CMakeFiles/systemmonitor.dir/ksystemactivitydialog.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3206:
systemmonitor/CMakeFiles/systemmonitor.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
*** Failure: Exit code 2 **
```*
Maybe this is a real fix, may not.
BTW, I'm very curious to know why libksysguard and ksysguard compile
without this patch, while plasma-workspace does not.
REPOSITORY
R111 KSysguard Library
BRANCH
plasma (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10623
AFFECTED FILES
processcore/processes.h
To: michaelh, #plasma, #plasma_workspaces
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
