ngraham added a comment.
Looks awesome, +1 from me feature-wise. Just a few a naive code comments for now. INLINE COMMENTS > ksysguardprocesslist.cpp:360 > > - > //Sort by username by default Let's do unrelated whitespace/style cleanup in another patch. > ksysguardprocesslist.cpp:486 > + > d->mUi->btnKillProcess->setEnabled(d->mUi->treeView->selectionModel()->hasSelection()); > + d->mUi->treeView->scrollTo(d->mUi->treeView->currentIndex()); > } Let's do unrelated whitespace/style cleanup in another patch. > ksysguardprocesslist.cpp:525 > d->mNumItemsSelected = numSelected; > - d->mUi->btnKillProcess->setEnabled( numSelected != 0 ); > + d->mUi->btnKillProcess->setEnabled(numSelected != 0); > Let's do unrelated whitespace/style cleanup in another patch. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
