broulik added a comment.

  > every time I changed konsole tabs, saved a file in kate, the appDataFromUrl 
(missed the cache) was called.
  
  Whenever `NET::WMVisibleName ` changes, both caches are evicted. It might be 
worth checking what's more expensive to create, the `KWindowInfo` or `AppData` 
and then use one or the other depending on it, e.g. use the `KWindowInfo` for 
the `visibleName` and don't nuke the `appDataCache` when that changes, or so. 
I'm not very familiar with that codebase.

INLINE COMMENTS

> xwindowtasksmodel.cpp:330
>          wipeInfoCache = true;
> -        wipeAppDataCache = true;
>          changedRoles << Qt::DisplayRole << Qt::DecorationRole << AppId << 
> AppName << GenericName << LauncherUrl << AppPid;

However, just *not* killing the cache would lead to `DisplayRole`, `AppId`, 
`AppName`, `GenericName` not updating as these are taken from `appData` in 
`data()`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to