broulik added a comment.
Just some minor points, feel free to ignore
INLINE COMMENTS
> plotter.cpp:288
> setFlag(ItemHasContents);
> + connect(this, &Plotter::windowChanged, this, [this]() {
> + if (m_window) {
Override `QQuickItem::itemChange` instead of a `connect`
> plotter.cpp:726
>
> - QSGSimpleTextureNode *n = static_cast<QSGSimpleTextureNode *>(oldNode);
> + ManagedTextureNode *n = static_cast<ManagedTextureNode *>(oldNode);
>
Did you try `setOwnsTexture`?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D10250
To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, ngraham, plasma-devel, #frameworks, michaelh,
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
