davidedmundson added a comment.
Note that the unit test doesn't touch any of the code you modified, it
passing isn't a sign of anything.
Does 5.8 need fixing?
INLINE COMMENTS
> fvogt wrote in notificationsengine.cpp:266
> I don't like magic numbers, maybe `sizeof("<?xml
> version="1.0"><html></html>")-1`?
strlen not sizeof
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10315
To: broulik, #plasma, davidedmundson, aacid, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
