ngraham added a comment.

  Thanks for doing this! A few notes:
  
  - Put "BUG: 358930" on its own line in the Summary; this will cause that bug 
to get closed once this goes in.
  - Put "Depends on https://phabricator.kde.org/D10305"; on its own line in the 
Summary to mark that this patch requires the changes introduced in that other 
one.
  - No need to mention the bug number in the title (which becomes the commit 
message).
  - You'll want to mark Réne as the author; to do this, first do `git commit 
--amend --author=" René Fürst <r...@fuerst.biz>"` and then `arc diff` to update 
the diff.

REVISION DETAIL
  https://phabricator.kde.org/D10304

To: lshoravi, #plasma, #plasma_accessibility
Cc: ngraham, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to