ngraham added a comment.

  The UI is much better now! Looks great and works fine. If you can't easily 
figure out how to make ctrl+c work, that's fine for now, and we can investigate 
that in a later patch.

INLINE COMMENTS

> Module.cpp:29
>  #include <KAboutData>
> -#if KCOREADDONS_VERSION >= QT_VERSION_CHECK(5,20,0)
>  #include <KCoreAddons>

Is this necessary for this patch? If not, let's address it in a different patch 
or commit.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

Reply via email to