ngraham added a comment.
In https://phabricator.kde.org/D10027#194446, @anemeth wrote: > In https://phabricator.kde.org/D10027#194443, @apol wrote: > > > Please modify appendIfValid to not add duplicates. > > > What do you mean? > In what situation would it add duplicates? > This change is to make sure it does not add duplicates. He's saying that you should make the change //inside// appendIfValid() instead of duplicating 4 times the same code that //calls// appendIfValid(). Thanks for the patch, BTW! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10027 To: anemeth, apol, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
