broulik created this revision. broulik added reviewers: Plasma, VDG, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY This finds bookmarks by querying the browser which is a lot less fragile than poking the browser's database files manually. TEST PLAN F5664124: Screenshot_20180119_172839.png <https://phabricator.kde.org/F5664124> Results are also a lot more sensible One major disadvantage I just now realized is that when the browser isn't running it won't work :/ The DBus API was quite straight-forward to work with, perhaps "subtext" could be part of the struct, but then, usually you also have urls, and then you add a gazillion properties to the struct? I think we could have the xml and structs be installed by krunner somehow, so we don't end up with copies all over the place REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D9984 AFFECTED FILES extension/_locales/en/messages.json extension/constants.js extension/extension.js extension/manifest.json extension/options.html host/CMakeLists.txt host/bookmarksrunnerplugin.cpp host/bookmarksrunnerplugin.h host/dbusutils_p.h host/main.cpp host/org.kde.krunner1.xml host/plasma-runner-bookmarks.desktop To: broulik, #plasma, #vdg, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
