jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed.
Could you also add support for RSA SecurID so support for tokens is complete? I'm also not sure whether with this the support is complete, because you need to also add this to authentication dialog if I'm not mistaken. See https://bugs.kde.org/show_bug.cgi?id=338650. INLINE COMMENTS > openconnectwidget.cpp:111 > + if (d->ui.cmbProtocol->currentIndex() != > OpenconnectSettingWidgetPrivate::Disabled) { > + > d->ui.leTokenSecret->setText(secrets.value(NM_OPENCONNECT_KEY_TOKEN_SECRET); > + } Missing bracket at the end. REVISION DETAIL https://phabricator.kde.org/D9746 To: scarpino, jgrulich Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
