apol added inline comments.

INLINE COMMENTS

> Kanedias wrote in plasmadesktoptheme.cpp:160
> I didn't quite get it, you mean we can write `for (auto state : { 
> QPalette::Active, QPalette::Inactive, QPalette::Disabled })` to get rid of 
> allocation of `states` array?

Yes, or `static const auto states = { QPalette::Active, QPalette::Inactive, 
QPalette::Disabled };`
Shouldn't be much of a difference.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D9803

To: Kanedias, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

Reply via email to