hpereiradacosta added inline comments. INLINE COMMENTS
> hpereiradacosta wrote in breezestyle.cpp:5041 > This whole code feels hackish. > In principle we know (elsewhere in the code), if any part of the scrollbar is > hovered, since it is used to make the groove appear. > I checked that this is done in a separate method though, namely > Breeze::Style::drawScrollBarComplexControl, which calls the base class method > in the end, which in turn ends up calling this method. > I wonder if we should not simply move the code from > drawScrollbarSliderControl to the ComplexControl method, thus making the > hacking above unnecessary. (makes sense ?) One possibility, maybe, would be to call drawScrollbarSliderControl explicitely in drawScrollBarComplexControl rather than letting the parent class method do that, and just pass it a modified (smaller) rectangle when not mouseovered. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
