ngraham added a comment.

  I can make the spinbox not affect menus; good catch. This was a pre-existing 
bug, but it gets bigger with the patch.
  
  Increasing the maximum value makes sense. Will do.
  
  I'd rather not make this an option, for all the reasons that have already 
been articulated on the subject. Since the status quo was never particularly 
RTL-aware in the first place, can we tackle that in a follow-up patch rather 
than overloading this one?
  
  Will work on HiDPI, good catch. I agree, we should always test that. I'll 
make a note for my future patches.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9549

To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake
Cc: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

Reply via email to