rkflx created this revision. rkflx added a reviewer: hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY Gwenview's Operations sidebar uses custom `QToolButtons` which are wide and left aligned. Special support for this in Oxygen was added with https://phabricator.kde.org/R113:b33942690c65e38d40d3b8329d2bb6a9a0a6d7ce. However with the transition to KF5 something broke: While the alignment to the left still worked, there was not enough space between the left button border and the icon (Screenshots from the matching Diff for Breeze, see https://phabricator.kde.org/D9281): F5539728: 1_gwenview-toolbutton-margins_before.png <https://phabricator.kde.org/F5539728> This is fixed by adding the appropriate margin: F5539730: 2_gwenview-toolbutton-margins_after.png <https://phabricator.kde.org/F5539730> Note how this replicates exactly the spacing of the toolbuttons in the regular toolbar on the top (which had its icon size set to "small" in this screenshot). CCBUG: 381535 TEST PLAN Icons on toolbuttons in Gwenview's Operations sidebar no longer squished all the way to the left, text spacing still looking good. REPOSITORY R113 Oxygen Theme BRANCH master REVISION DETAIL https://phabricator.kde.org/D9282 AFFECTED FILES kstyle/oxygenstyle.cpp To: rkflx, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart