graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY The regression got introduced with https://phabricator.kde.org/R108:9934f5b57537feae54afd0c4366c90253638ada2. The order when setMaximize(false, false) was called changed in regard to when the quick tiling mode was adjusted. But just changing the ordering back was no solution as that would cause regressions in other areas (unit tests fail). This change builds up on the support for geometry update blocker on Wayland to be able to better support this situation without causing further regressions. Also this change rethinks the code area. There is an idea behind temporarily setting the quick tile mode to none and that is even documented in a comment: it should not confuse maximize. So let's do exactly that: call the maximize in the block where the quick tile mode is temporarily wrong. As that is only one branch the else branch performs the same steps. BUG: 376104 FIXED-IN: 5.12.0 TEST PLAN Confirmation in bug report that patch fixes issue REPOSITORY R108 KWin BRANCH fix-quick-tiling-maximize REVISION DETAIL https://phabricator.kde.org/D9178 AFFECTED FILES autotests/integration/quick_tiling_test.cpp geometry.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart