davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land.
Personally I'd have just set a parent when creating the new KNS3::DownloadDialog. If someone ever did change this code so it deletes on close, the old code would have handled it, this won't. But this is also fine. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9131 To: anthonyfieroni, davidedmundson, broulik Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
