davidedmundson added inline comments.
INLINE COMMENTS
> GridView.qml:32
> +
> + implicitWidth: Math.max( Math.min(parent.width, cellWidth * 2 +
> scroll.scrollBarSpace)
> + , Math.floor(view.availableWidth / cellWidth) * cellWidth +
> scroll.scrollBarSpace + 4)
It never ever makes sense for an item's implicitSize to be based on the
parent's current size.
It's up to the parent to increase this item's actual width to be bigger than
the implicitWidth
> thememodel.cpp:305
> {
> - bool haveCursors = themeDir.exists(QStringLiteral("cursors"));
> + bool haveCursors = themeDir.exists("cursors");
>
why change these QStringLiterals? Is a rebase needed?
> thememodel.cpp:321
>
> + static bool isX11 = QX11Info::isPlatformX11();
> + if (!isX11) {
This seems unrelated, adn I'm not sure is right.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8692
To: mart, #plasma
Cc: davidedmundson, aspotashev, januz, ngraham, subdiff, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
