anthonyfieroni added inline comments.
INLINE COMMENTS
> input.cpp:1734-1738
> connect(conn, &LibInput::Connection::eventsRead, this,
> [this] {
> m_libInput->processEvents();
> }, Qt::QueuedConnection
> );
Doesn't it to be in setup?
void Connection::setup(QObject *to)
{
connect(this, &LibInput::Connection::eventsRead, to, [this]() {
processEvents(); }, Qt::QueuedConnection);
QMetaObject::invokeMethod(this, "doSetup", Qt::QueuedConnection);
}
Caller should be
conn->setup(this);
Otherwise it looks inconvenience, no?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8888
To: fvogt, #plasma, graesslin, davidedmundson
Cc: anthonyfieroni, ngraham, kwin, #kwin, plasma-devel, bwowk, ZrenBot,
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas,
apol, mart
