davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > framesvgitem.cpp:295 > + > + const QVector<qreal> m_oldMargins; > + FrameSvgItemMargins *const m_margins; If we always have 4 and can initialised them to 0 qreal[4] with a c style array would be better. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
