amantia added inline comments. INLINE COMMENTS
> mwolff wrote in screenmapper.cpp:108 > `m_itemsOnDisabledScreensMap` stores "names" from the `m_screenItemMap`, so I > think this line here is wrong and should also use the proposed > `screenUrlForPath` above, or `QUrl::fromUserInput`, no? Otherwise you may end > up with relative urls for file paths? I don't understand the problem. Yes m_itemsOnDisabledScreensMap is storing the names (well, paths) from m_screenItemMap. They will be in a format like file://foo or desktop://foo or similar. screenPathWithScheme is the base path for the screen which is either file://SOMEPATH (or some other scheme) or desktop:/ . The check is to see if the items from the disabled screen map are under this path or not. I don't see where we can get relative paths. I might miss something though, but I don't know what. :) > mwolff wrote in screenmapper.cpp:140 > is `name` also a `path`? Basically yes, it is a path with scheme, but I renamed from "url" to "name" to be clear this is not a QUrl. I can change to path, although that is not exactly correct either, as the scheme is included. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
