mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in FormLayout.qml:121
> In general with text, I think it's better to set the item to occupy the whole 
> space it /can/ take up, then use the Text.Alignment property to position the 
> text within it.
> 
> Otherwise if this wraps, your second line would start on the left not the 
> right.
> 
> Related; what should happen if a user sets a really really really long label?

I tried that, but it messes with the gridlayout size hints and then i get the 
whole layout aligned at the right of the parent instead of the left

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8641

To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein

Reply via email to