davidedmundson added a comment.

  Mostly ship it, but I noticed something in the docs when I was checking the 
matrices.

INLINE COMMENTS

> device.cpp:464
> +    }
> +    libinput_device_config_calibration_set_matrix(m_device, matrix.data());
> +}

Shouldn't we be multiplying the default matrix for the device by the matrix 
you're generating here then setting that?

If a user has set a static calibration we want to keep that.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8748

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

Reply via email to