mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > datamodel.h:141 > protected: > - int roleNameToId(const QString &name); //FIXME TODO KF6: This should > have been const. > + int roleNameToId(const QString &name) const; > bool filterAcceptsRow(int source_row, const QModelIndex &source_parent) > const Q_DECL_OVERRIDE; why was that kf6 note there? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8639 To: broulik, #plasma, mwolff Cc: mwolff, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
