sebas added a comment.

  Once you're done with the code, please also add screenshot so usability can 
have a look at it. I'm not sure we should add UI for this, the screen setup is 
already very complex and hard to understand. Perhaps a set of clear use-cases 
would make this clearer?
  
  No unit tests for the code (I know, hard to do) will add to the maintenance 
burden, which is already high.
  
  Just seeing the code is definitely not enough for me to ACK this.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

Reply via email to