graesslin added inline comments.
INLINE COMMENTS
> desktopview.cpp:60
>
> - connect(this, &DesktopView::sceneGraphInitialized, this,
> - [this, corona]() {
> - // check whether the GL Context supports OpenGL
> - // Note: hasOpenGLShaderPrograms is broken, see QTBUG--39730
> - if
> (!QOpenGLShaderProgram::hasOpenGLShaderPrograms(openglContext())) {
> - qWarning() << "GLSL not available, Plasma won't be
> functional";
> - QMetaObject::invokeMethod(corona,
> "showOpenGLNotCompatibleWarning", Qt::QueuedConnection);
> - }
> - }, Qt::DirectConnection);
> + if (QQuickWindow::sceneGraphBackend() != QLatin1String("software")) {
> + connect(this, &DesktopView::sceneGraphInitialized, this,
Is it correct to compare to software? What if vulkan get's introduced?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8012
To: davidedmundson, #plasma, broulik
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
