graesslin added inline comments.
INLINE COMMENTS
> contrast.cpp:79
> + }
> + foreach (EffectWindow *window, effects->stackingOrder())
> + updateContrastRegion(window);
please no foreach in new code, please use range-based for. (Reason: I don't
trust Qt to keep it after there was a prominent blog post about deprecating
foreach)
> contrast.cpp:79-80
> + }
> + foreach (EffectWindow *window, effects->stackingOrder())
> + updateContrastRegion(window);
> }
Please use {}
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7937
To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff,
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
